West Coast if you like wildlife *SoCal to Seattle depending on your affinity for cold water*, somewhere between NC and NJ if you like wrecks *though they're getting destroyed quickly*, and Florida for all around diving. I wouldn't want to live in the Great Lakes region because of the limited diving season due to the ice.
If I had to choose, it would probably be Tampa. Close wreck diving, close shore diving, 5 hours to Marianna caves, 3 hours to Peacock area, 5 hours to Key Largo which is easily doable for weekends. On the gulf side so no real risk of hurricanes, Major city for flying around. Water is warm all year, though the summers are brutal, but for overall if I had to choose one place for best overall balanced diving, it would probably be Tampa. Not necessarily the best in any one type of diving, but proximity to everything it is probably the best overall. If you're a cave diver, you're far better off going to Gainesville or Tallahassee, reef diver to Largo, wrecks to NC. all obviously my opinion