My personal view:
If you like to instruct and/or guide people go for it.
As a recreational instructor you will learn to execute all skilla perfectly. You will have lots of dives, but probably more easy ones with beginners. Its different from diving on your own.
To actually make money and a living from it, you first have to put work and money in, then you need to work quiet a lot of diving courses. But you have the freedom, lots of diving and people, different destinations, working in nature and so on. Depends on your life goals.
The other option of getting better in diving would be to pursue technical courses, find a technical dive buddy, with whom you practice frequently. In that case it woulf stay a hobby.
I think turning a hobby into a profession is difficult as the views, engagement and also dependence on it changes.
Third option would be to find a job that.combines both like marine research.