Question: for warm water recreational diving at a resort with an onsite dive shop that I'll be diving with--should I need to worry about a save a dive kit? I would think they'd be able to help servicing things should something go wrong, but I'm not really sure as I've always rented in the past but will be schlepping my own gear this trip.
Similar to what others have stated above, this is for quick resolutions when out on a day trip boat. I also own my own equipment, so it's more my responsibility than rental from a resort/shop.
For a week-long live aboard I'd prob add a few things, such as the wrench I mentioned, and if with a group might even add a spare reg if available.
I've also worked as an instructor, so being ready to replace an o-ring on a yoke valve or tighten a loose hose are simple fixes and teach students to check their equipment, be prepared, and responsible for themselves. Straps break, o-rings get blown off valves, batteries wear out.
For example, those LR44 batteries are for a
marker light I have attached to the top of my dSMB, I just keep it rolled up inside. I also have a second constant-on one I will attach to my tank valve when teaching AOW night dives. Makes it easy for people doing their first night dive to see/track me as the instructor. I wouldn't expect to be able to find those in some random shop, so I pack them myself (although only had to replace them once in 4 years).
Side note: ideally don't store batteries (coin, rechargeable, regular) loose so they can randomly touch each other. Might not be able to see, but I have thin cardboard between each row of those LR44s. Can easily drain each other, or worse case cause a fire. I have a
simple case for 18650 (flashlight) batteries for the same reason.