For 3AL (aluminum) 3AA (steel) tanks the DOT requires the burst disk rupture at a pressure within a range of 5/3rds the service pressure to 10% less than 5/3rds the service pressure. So for a tank with a 2250 psi service pressure, you need a disc that will fail between 3750 psi and 3375 psi. The 5/3rds figure is based on the same 5/3rds pressure requirement for hydrotesting of 3AA and 3AL tanks and essentially ensures the tank will not be subject to more than its test pressure.
Other tanks certified under DOT exemptions may have less conservative test pressures of 1.5 to 1.7 times their service pressure and woudl consequently need a burst disc to match the test pressure.
A disc that would rupture at 3000 psi would have been intended for a 3AA steel tank with an 1800psi service pressure. Over time the disc flexes with each fill cycle and the pressure they will actually fail at decreases, so the concern with using a 3000 psi rated burst disc in a 2250 psi tank would be that it would fail due to age/corroision or cycles slightly sooner than the correct 3375 to 3750 psi rated disc. It is safe from an explosion standpoint, but would slightly increase the potential for a burst disc related OOA situation.
Valves usually come marked with the service pressure of the tank they are intended to be used in (3000 psi for example for the average AL 80) and the disc would need to be changed for 2250 psi service as the disc for a 3000 psi tank will not burst until a pressure of between 4500 and 5000 psi is reached -well over the test 3750 psi test pressure for a 2250 psi steel tank.
The saving grace here is that for the most part all tanks with a given service pressure are all certified under the same standards or exemptions so marking the packaging for the burst disc asssembly by tank service pressure works and it saves the average tank monkey from having to do higher math like multiplying the service pressure by 5 and then dividing by 3 or more legitamately, having to understand the hydro test requirement for various exempt tanks that may be encountered.
What bothers me most here is the LDS taking advantage of the diver by suggesting the old valve needed to be replaced at all when a $6.00 burst disc assembly would have worked fine. Sometimes if the valve is old and needs to be rebuilt as well as have the burst disc replaced, it cna be more economical to just replace the valve, but the choice to do that should remain with the customer and the LDS should give them all the options.
It is less galling that LDS insisted on tumbling the tank - but not much. Part of it might be price gouging, but some of it may have just been ignorance about what level of flash rusting is acceptable. If it is not heavy enough to interfere with a visual inspection by potentially hiding an underlying pit and if it is not clumping together in heavier spots that could hold moisture and lead to pitting, tumbling is not required. Either way, I'd find a new dive shop.