There are pros and cons. For what ever reaosn the DOT seems to be ok with the visual inspection done at requalification being done prior to the hydro test. I have however seen previously unobserveable cracks in 6351-T6 alloy tanks propoate during the hydro test to the point they were now detectable. That argues for a post hydro VIP and visual eddy, not one done prior to the test. In my opinion, the only advantage of doing the VIP first is to exclude the a tank that wil fail from the entire hydro test procedure.
But, crack issues aside, as noted in other posts above, it is imperative to at least look in the tank post hydro test to ensure it is dry and does not contain foreign objects, visible contaminants or excessive flash rust or corrosion.
So unless the shop knows that the test facility does this and then properly seals the tank toprevent contamination, the LDS needs to do a VIP and at a minimum at least needs to peak inside.
Charging for that additional VIP is a separate issue. The LDS will be marking up the cost of the hydro (probably 100%, so they are already making money on it and they will be making money on the fill. Given that the scope of their VIP in this context is less, that the cost of the VIP sticker itself is minimal and that they have already made money off the hydro and VIP done as part of the requalification, it is gouging the customer to look in the tank to ensure it is dry, non rusted/corroded and has no visible contaminants, and then slap a sticker on it.
A legitamate exception here is I think 6351-T6 tanks given the potential that the hydro test is done after the VIP at the hydro facility and that a crack could be present post hydro test.
O2 cleaning is also a separate issue with separate tolerances for a VIP. For example, given the isses with entrained particles I won't tolerate any flash rust in an O2 clean tank, but would not worry about it during the VIP of a tank to be used with air only provided it had not progressed to the point where it may prevent proper inspection of the tank, hide pitting, or concentrate moisture and promote pitting.