I hate them. I guess it is a matter of location. My experience in the Red Sea and Asia is that you can get multiple boats at a site, with literally dozens of diveguides using bangers and shakers for every single shrimp, nudi and parrotfish that they come across.
...and then they wonder why they don't see many sharks or dolphins...
I suppose if it is a single buddy team using them...and they are the only people on a site, then it is acceptable. Other people's noise is always far more annoying than your own.
However, I love to dive because it is peaceful, tranquil and silent. Tank bangers, shakers and horns are the Devil's spawn when it comes to getting into the 'zone'.
For me, they are simply compensation for bad buddy awareness. I've never used a banger...and yet I've never had problems with letting my customers know "I've found something cool".