The controversy involves whether the marketing of a product is so successful that it inadvertantly creates unintended hazzards.
Spare Air is a classic case study in marketing. Who among us wouldn't think its a great idea to have a little bonus when running low on air. So take a nice, small, compact product, get it introduced into a very cool Baywatch series, keep it simple by removing the need for extra stuff (like those silly complicated regulators), then market it in ads that show how you'll never run out of air! Just the right formula for an instant sales advantage, particular to novice divers or their worried parents.
So where's the controversy? To understand the utility of the product, you'd have to do the dreaded M word -- MATH! A diver who knows his/her breathing rate (SAC or RMV or other variation) will know how many normal breaths of air are in the Spair Air cylinder, then would calculate how many OHMIGAWDI'MOUTOFAIR breaths are in that same bottle, and then factor in depth, where it could take 2,3,4 or more times the amount of air to get that same single breath at the surface. A little complex, especially since most divers have only a cursory awreness of how that all works (thanks to the other conroversy -- the weekend certification class).
As a result, there are lots of folks who shell out $200+ for a product, and then are convinced that it will benefit them in an OOA situation. The Problem: in the real world, they'll gain just 2-4 breaths of air max in a real OOA situation. So what's wrong with that? During the time they are fumbling around with it, they could be getting to the surface. AND, for the same price, they could:
1. Learn more about their own real air consumption;
2. Learn to monitor their air and become better, problem-preventive divers;
3. Purchase equipment that really holds enough air for an emergency.
And there would not have been a dumbing down of the importance of air management, or the sale of a very false sense of security.
And for NO price they could improve their buddy skills, practice air sharing, develop an SPG check habit, etcetcetc.
Its only controversial to those who stand to make or lose money on the sale, or a sense of pride in their wise decision to buy one. OTOH, they are very cool when you are cleaning the bottom of the pool (as long as you're certified and know not to hold your breath - its still compressed air <albeit not very much> and you can still embolize in a pool).