My thoughts when I read the "noise" thing was "oh...he may have encountered a less than stellar tech".
That's not entirely fair as in some rare cases you can have a rough/scored piston stem that will vibrate (which is then heard as a high pirched whistling sound) that may not present itself for a few dives post service. And in some very old and well worn flow through piston first stages, excessive tolerances between the piston and reg body along with high pressure tanks in the 3500-3600 psi range can cause pinching of the HP o-ring, which over the course of several dives can then can be rough and start causing the piston to vibrate.
But in most cases, the whistling is due to inadequate initial lubrication of the piston stem o-ring and that is a tech issue.
---
You could argue that a diaphragm reg ages better or lasts longer, but that's a hard argument to make given that some piston regs like the Mk 5 have been around since the late 1960s and in many cases have been updated with 4 or 5 port turrets, keeping them viable that whole time. In comparison, diaphragm regs like the Conshelf 11, 12, 14 and later models have been around almost as long, but the older 11 and 12 are now seldom used as they lack a sufficent number of LP ports. Which means the Mk 14s that may have seen continous use are all a decade younger than some of the oldest Mk 5s that are encountered.
One of the shops I work still has Mk 5s in rental and while some of them have bene retired over the last few years, they have seen long, hard use over a nearly 40 year career and I doubt any reg design woudl have done better.
Which is to say: 1) it's not the age, its the mileage and 2) any qualitative differences in longevity between piston and diaphragm regs will be lost in the noise of differences in use, maintenence and number of breathing cycles.