Well, a lot is going to depend on one's priorities. A person who vastly prefers warm water diving is going to make different choices from someone who is equally comfortable in cold. Climate varies, and some people don't like cold, and other don't like heat. Island locations have issues with limited supplies and high prices, as well as the necessity to fly for a change of scenery.
Personally, I prefer a temperate climate, leaving someplace like Florida out as a residence due to heat, humidity, and hurricanes. I don't mind cold water diving (and sometimes wonder if I prefer it), so the West Coast is a good place for me. California has better weather, but higher prices and some really messed up politics and social problems. And Californians have to dive in water that MOVES
Washington has lower prices than California (somewhat) but you have to like cooler temps and rain. On the other hand, Puget Sound is diveable darned near 365 days a year, and it's GOOD diving.
In your situation, if I could afford it, I'd think about snowbirding -- living one place during the winter, and another during the summer, both of them near good quality diving.
Personally, I prefer a temperate climate, leaving someplace like Florida out as a residence due to heat, humidity, and hurricanes. I don't mind cold water diving (and sometimes wonder if I prefer it), so the West Coast is a good place for me. California has better weather, but higher prices and some really messed up politics and social problems. And Californians have to dive in water that MOVES

In your situation, if I could afford it, I'd think about snowbirding -- living one place during the winter, and another during the summer, both of them near good quality diving.