Simply repeating the same basic dives over and over again will do nothing to move you to an advanced level of diving
I disagree with this. It depends on where you set the bar...
Doing the same basic dives over and over again won't necessarily raise the bar to a more advanced level of diving, whether the dive site is for novices or highly advanced. Critically looking at what you are doing during dive planning, during the dive and post-dive, analyzing what you could do better, and working on that the next and all future dives is one path to moving to a more advanced level of diving. After all, even in the confined water of a swimming pool, there are always some skills to work on improving, whether it's buoyancy, propulsion, trim, equipment configuration and usage, or other skills.
I dive a lot of the same dive spots, because they are convenient, familiar and enjoyable, and mentally I'm always trying to improve my diving skills so they become less and less advanced. This doesn't necessarily diminish the enjoyment of the site in the long run, and in many ways makes the site more enjoyable, because I can concentrate on the nuances and details of the site, rather than characteristics that make the site at all advanced or challenging. Sometimes I'm kicking myself afterward for not improving on something I noted in an earlier dive, and especially for making the same boneheaded mistakes I set out to stop making. Not necessarily directly related to the original question of what makes a dive site advanced, but certainly one technique for being better prepared for advanced dive sites in the future, and making sites less advanced
Of course, familiarity and/or over confidence (because a site is not particularly advanced) can lead to complacency, and that's where divers get into trouble, whether the site is an advanced one or not