Dahab is laid back, relatively cheap, uncrowded, quiet, nearly 100% divers. Excellent divesites, with an option to go on excursions to Sharm/Thistlegorm. Camel safari nice.
Sharm is pricey, touristy, more non-divers than divers, plenty nightlife. Good sites, again - crowded! Coral damage...